YARN-11907: Fix queue starvation in FairSharePolicy when demand=0 but…#8127
Open
ryukobayashi wants to merge 4 commits intoapache:trunkfrom
Open
YARN-11907: Fix queue starvation in FairSharePolicy when demand=0 but…#8127ryukobayashi wants to merge 4 commits intoapache:trunkfrom
ryukobayashi wants to merge 4 commits intoapache:trunkfrom
Conversation
… pending apps exist
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fix queue starvation in FairSharePolicy when queues have pending applications
Problem
FairSharePolicy causes queue starvation when a queue has pending applications waiting for AM allocation but no running containers yet (demand=0, getNumRunnableApps()>0). The queue receives no allocations despite having pending applications and
configured minShare guarantees.
Root Cause
compareDemand() treats all queues with demand=0 as empty and assigns lowest priority, blocking progression to minShare comparison stage.
Solution
Modified compareDemand() to distinguish truly empty queues (getNumRunnableApps()==0) from queues with pending applications (getNumRunnableApps()>0). Queues with pending applications now progress to minShare comparison, preventing starvation.
Testing
Added TestFairSharePolicyPendingApps with 4 test cases covering pending app scenarios and minShare comparison.
How was this patch tested?
Add the unit test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?